Remove unused IntraProcessMessage

[brawner]

IntraProcessMessage is no longer used except as a dummy message in rclcpp tests. This removes the message from rcl_interfaces and creates an empty message in test_msgs for those rclcpp tests. rclcpp doesn't depend on common_interfaces, but it already depended on test_msgs so this doesn't change its dependency count.

If reusing common_interfaces/empty.msg is better than creating an empty message I can switch to that instead.

[brawner]

See also ros2/rclcpp#1017

[brawner]

• Linux
• Linux-aarch64
• macOS
• Windows

[ivanpauno]

Can you move the Dummy msg here https://github.com/ros2/test_interface_files/tree/master/msg?
Thanks!

[dirk-thomas]

Creating a Dummy.msg for this case seems overkill. If the tests can use an existing message definition instead that would be preferred. If they can't it would be good to state the rationale why.

[brawner]

Thanks @ivanpauno for the suggestion. It looks like there is already an Empty message there, so I'm going to use that instead for rclcpp. Latest commit removes Dummy.

• Linux
• Linux-aarch64
• macOS
• Windows

[brawner]

Retesting:

• Linux
• Linux-aarch64
• macOS
• Windows

[brawner]

@ivanpauno @wjwwood The tests now pass. If someone could merge this for me, I would appreciate it.

[ivanpauno]

@ivanpauno @wjwwood The tests now pass. If someone could merge this for me, I would appreciate it.

Merged both this PR and the one in rclcpp.

[brawner]

Thank you!

…

On Fri, Mar 20, 2020 at 12:37 PM Ivan Santiago Paunovic < ***@***.***> wrote: @ivanpauno <https://github.com/ivanpauno> @wjwwood <https://github.com/wjwwood> The tests now pass. If someone could merge this for me, I would appreciate it. Merged both this PR and the one in rclcpp. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7D6ULHVKOXFZOXRRD36LRIPAXRANCNFSM4LCW7NRA> .