Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on rosidl_core_generators for packages required by actions #144

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Depend on rosidl_core_generators for packages required by actions #144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba50a5c
Depend on rosidl_core_generators for packages required by actions
jacobperron Aug 2, 2022
5264685
Remove action_msgs dependency from test_msgs
jacobperron Aug 2, 2022
512446b
Depend on rosidl_core_runtime for packages depended on by actions
jacobperron Aug 18, 2022
1817107
Update quality declarations
jacobperron Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion action_msgs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ endif()

find_package(ament_cmake REQUIRED)
find_package(builtin_interfaces REQUIRED)
find_package(rosidl_default_generators REQUIRED)
# Depend on "core" generators instead of "default" generators
# because ROS actions depend on this package
find_package(rosidl_core_generators REQUIRED)
find_package(unique_identifier_msgs REQUIRED)

set(msg_files
Expand Down
2 changes: 1 addition & 1 deletion action_msgs/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<author email="michel@ekumenlabs.com">Michel Hidalgo</author>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>rosidl_default_generators</buildtool_depend>
<buildtool_depend>rosidl_core_generators</buildtool_depend>

<depend>builtin_interfaces</depend>
<depend>unique_identifier_msgs</depend>
Expand Down
4 changes: 3 additions & 1 deletion builtin_interfaces/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
endif()

find_package(ament_cmake REQUIRED)
find_package(rosidl_default_generators REQUIRED)
# Depend on "core" generators instead of "default" generators
# because ROS actions depend on this package
find_package(rosidl_core_generators REQUIRED)

rosidl_generate_interfaces(${PROJECT_NAME}
"msg/Duration.msg"
Expand Down
2 changes: 1 addition & 1 deletion builtin_interfaces/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<buildtool_depend>ament_cmake</buildtool_depend>

<buildtool_depend>rosidl_default_generators</buildtool_depend>
<buildtool_depend>rosidl_core_generators</buildtool_depend>

<exec_depend>rosidl_default_runtime</exec_depend>

Expand Down
1 change: 0 additions & 1 deletion test_msgs/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<build_depend>builtin_interfaces</build_depend>
<build_depend>test_interface_files</build_depend>

<depend>action_msgs</depend>
<exec_depend>builtin_interfaces</exec_depend>
<exec_depend>rosidl_default_runtime</exec_depend>

Expand Down