Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clang warning about possible uninitialized variable #21

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Fix Clang warning about possible uninitialized variable #21

merged 1 commit into from
Oct 7, 2019

Conversation

jacobperron
Copy link
Member

@jacobperron
Fix Clang warning about possible uninitialized variable
733a56e 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added in review bug Something isn't working labels Oct 5, 2019
wjwwood
wjwwood approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I just ran into this after pulling on my macbook (I use -W=error).

@dirk-thomas dirk-thomas mentioned this pull request Oct 6, 2019
Closed
clalancette
clalancette approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@jacobperron
Copy link
Member Author

@ros-pull-request-builder Please retest this

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit fc3a6f3 into master Oct 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_clang_warning branch October 7, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
bug Something isn't working in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobperron @wjwwood @clalancette