Make spdlog an exec_depend.

[clalancette]

Newer spdlog (>= 1.5.0) builds a shared library, so we
need to add an exec_depend now.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Part of solving #26

[dirk-thomas]

Doesn't it also export the dependency in CMake?

[clalancette]

Doesn't it also export the dependency in CMake?

So I did a full build of the ros2 workspace without this, and it succeeded. I then tested out some of demo_nodes_cpp, which also succeeded. I also did an overlay build which succeeded. So I'm not entirely sure if it is needed.

That being said, it is more correct so I'll add it. Thanks for the heads up.

[cottsay]

@clalancette - Can this be backported to Eloquent? I'm getting RPM build failures on Fedora because libspdlog.so.1 isn't installed because the spdlog dependency is missing.

[clalancette]

@clalancette - Can this be backported to Eloquent? I'm getting RPM build failures on Fedora because libspdlog.so.1 isn't installed because the spdlog dependency is missing.

I don't see why not. It will never be strictly needed on our Eloquent supported platforms, but it shouldn't hurt either. @cottsay Would you mind opening up the backport PR? I'll review it.