Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current state Quality Declaration, Contributing and Readme files #29

Merged
merged 9 commits into from
May 5, 2020

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Mar 20, 2020

This PR adds the current Quality Declaration claim for the rcl_logging_spdlog package. The current state is Quality level 4.

It will also add Contributing.md file to properly document License contributions and Readme pointing to current Quality Declaration.

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 marked this pull request as ready for review May 1, 2020 22:28
@Blast545
Copy link
Contributor Author

Blast545 commented May 1, 2020

Reformated to match new REP-2004 format

@Blast545 Blast545 requested review from ahcorde and brawner May 1, 2020 22:28
rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
rcl_logging_spdlog/README.md Show resolved Hide resolved
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributing file is missing

rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
@Blast545 Blast545 changed the title Progress toward Quality Level 1 Current state Quality Declaration May 4, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 changed the title Current state Quality Declaration Current state Quality Declaration, Contributing and Readme files May 4, 2020
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 requested review from brawner and ahcorde May 4, 2020 22:52
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix two minor fixes

rcl_logging_spdlog/Quality_Declaration.md Show resolved Hide resolved
rcl_logging_spdlog/Quality_Declaration.md Outdated Show resolved Hide resolved
Blast545 and others added 3 commits May 5, 2020 10:46
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 merged commit 7a4bcba into master May 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/qd_spdlog branch May 5, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants