Add some preliminary functional tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually we'll want to create a test to verify that we have spdlog configured correctly and can log data, but right now there aren't any good mechanisms to keep us from showering the ~/.ros/log/ directory with our log files. There also isn't a great way to determine exactly where the log ended up. I'll follow-up with changes to add more comprehensive testing when those mechanisms are available. Signed-off-by: Scott K Logan <logans@cottsay.net>
brawner
reviewed
May 14, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
brawner
approved these changes
May 15, 2020
|
I added in this PR https://github.com/ros2/rcl_logging/pull/37/files a function to check that the file is written properly |
Agreed. Some of the rcutils/rcpputils stuff I have lined up will make that better, anyway. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually we'll want to create a test to verify that we have spdlog configured correctly and can log data, but right now there aren't any good mechanisms to keep us from showering the
~/.ros/log/directory with our log files. There also isn't a great way to determine exactly where the log ended up.I'll follow-up with changes to add more comprehensive testing when those mechanisms are available.