Used current_path() function from rcpputils #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette
reviewed
Sep 17, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
clalancette
approved these changes
Sep 17, 2020
delete-merged-branch
bot
deleted the
ahcorde/remove_todo/current_path
branch
|
That using statement was pretty intentional. It made it so that when we switch to the C++ 17 filesystem API, all we had to do was switch the header and drop the using. |
This was referenced Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed TODO
Compiling up-to
rcl_logging_spdlogand testingrcl_logging_spdlogbecuse this change only affect the spdlog test.Signed-off-by: ahcorde ahcorde@gmail.com