Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rclc] Corrected unit test for rclc_executor service with context #231

Merged
merged 1 commit into from
Dec 17, 2021
Merged

[rclc] Corrected unit test for rclc_executor service with context #231

merged 1 commit into from
Dec 17, 2021

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Dec 17, 2021 •
edited

resolves #230
see also discussion in #223 (comment)

@JanStaschulat
resolved error in unit test see issue #230
3b50f8a 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat added the bug Something isn't working label Dec 17, 2021
@JanStaschulat JanStaschulat self-assigned this Dec 17, 2021
@JanStaschulat
Copy link
Contributor Author

@mergify backport galactic foxy

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2021 •
edited by JanStaschulat

backport galactic foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@JanStaschulat JanStaschulat changed the title resolved error in unit test for rclc_executor service with context [rclc] Corrected unit test for rclc_executor service with context Dec 17, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #231 (3b50f8a) into master (f79db48) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   63.42%   63.33%   -0.10%     
==========================================
  Files          16       16              
  Lines        2149     2149              
  Branches      641      641              
==========================================
- Hits         1363     1361       -2     
- Misses        472      473       +1     
- Partials      314      315       +1
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 58.59% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f79db48...3b50f8a. Read the comment docs.

@JanStaschulat JanStaschulat merged commit 5ea1a2a into master Dec 17, 2021
@JanStaschulat JanStaschulat deleted the bugfix/rclc_executor_unit_test_service_with_context branch December 17, 2021 09:41
mergify bot pushed a commit that referenced this pull request Dec 17, 2021
@JanStaschulat
resolved error in unit test see issue #230 (#231)
3729257 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit 5ea1a2a)
@mergify mergify bot mentioned this pull request Dec 17, 2021
Merged
mergify bot pushed a commit that referenced this pull request Dec 17, 2021
@JanStaschulat
resolved error in unit test see issue #230 (#231)
9711277 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit 5ea1a2a)
@mergify mergify bot mentioned this pull request Dec 17, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2021

backport galactic foxy

✅ Backports have been created

JanStaschulat added a commit that referenced this pull request Dec 17, 2021
@mergify @JanStaschulat
resolved error in unit test see issue #230 (#231) (#232)
2f965b1 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit 5ea1a2a)

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
JanStaschulat added a commit that referenced this pull request Dec 17, 2021
@mergify @JanStaschulat
resolved error in unit test see issue #230 (#231) (#233)
00fac45 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <jan.staschulat@de.bosch.com>
(cherry picked from commit 5ea1a2a)

Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norro norro norro approved these changes

@pablogs9 pablogs9 Awaiting requested review from pablogs9

Assignees

@JanStaschulat JanStaschulat

Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug fix: correct unit test for service with context
3 participants
@JanStaschulat @codecov-commenter @norro