Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter change event #310

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix parameter change event #310

merged 1 commit into from
Aug 23, 2022

Conversation

Acuadros95
Copy link
Collaborator

Signed-off-by: acuadros95 acuadros1995@gmail.com

Quick fix for parameter modifications notification:

  • Parameter value should be updated before rclc_parameter_prepare_changed_even is called.

@Acuadros95
Fix parameter change event
3b9b453 
Signed-off-by: acuadros95 <acuadros1995@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #310 (3b9b453) into humble (7a85616) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           humble     #310   +/-   ##
=======================================
  Coverage   69.13%   69.13%           
=======================================
  Files          16       16           
  Lines        2715     2715           
  Branches      765      765           
=======================================
  Hits         1877     1877           
  Misses        451      451           
  Partials      387      387
Impacted Files Coverage Δ
...lc_parameter/src/rclc_parameter/parameter_server.c 82.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pablogs9
pablogs9 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you take a look @JanStaschulat?

@pablogs9
Copy link
Member

Please backport to Rolling

JanStaschulat
JanStaschulat approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@JanStaschulat JanStaschulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Acuadros95
Copy link
Collaborator Author

@mergify backport master

@Acuadros95 Acuadros95 merged commit 786d95e into humble Aug 23, 2022
@Acuadros95 Acuadros95 deleted the fix/parameters_notify branch August 23, 2022 07:12
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@Acuadros95 @mergify
Fix parameter change event (#310)
9b39b7d 
Signed-off-by: acuadros95 <acuadros1995@gmail.com>

Signed-off-by: acuadros95 <acuadros1995@gmail.com>
(cherry picked from commit 786d95e)
@mergify mergify bot mentioned this pull request Aug 23, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2022

backport master

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Oct 4, 2022
@mergify @Acuadros95
Fix parameter change event (#310) (#311)
243ee63 
Signed-off-by: acuadros95 <acuadros1995@gmail.com>

Signed-off-by: acuadros95 <acuadros1995@gmail.com>
(cherry picked from commit 786d95e)

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@JanStaschulat JanStaschulat JanStaschulat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Acuadros95 @codecov-commenter @pablogs9 @JanStaschulat