Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example real-time concurreny timer and subscription (backport #329) #331

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2023

This is an automatic backport of pull request #329 done by Mergify.
Cherry-pick of fd648d9 has failed:

On branch mergify/bp/foxy/pr-329
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit fd648d9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclc_examples/README.md
	new file:   rclc_examples/src/example_short_timer_long_subscription.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclc_examples/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* initial example short timer long subscription duration

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>

* added delay in subscription

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>

* updated README

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>

---------

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
(cherry picked from commit fd648d9)

# Conflicts:
#	rclc_examples/CMakeLists.txt
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@codecov-commenter
Copy link

Codecov Report

Merging #331 (f8860e2) into foxy (02472d6) will decrease coverage by 2.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             foxy     #331      +/-   ##
==========================================
- Coverage   62.93%   60.32%   -2.62%     
==========================================
  Files          13       14       +1     
  Lines        1419     1555     +136     
  Branches      416      507      +91     
==========================================
+ Hits          893      938      +45     
- Misses        337      339       +2     
- Partials      189      278      +89     
Impacted Files Coverage Δ
...c_parameter/test/rclc_parameter/test_parameter.cpp 33.08% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JanStaschulat JanStaschulat merged commit 3e91bf1 into foxy Feb 8, 2023
@JanStaschulat JanStaschulat deleted the mergify/bp/foxy/pr-329 branch February 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants