-
Notifications
You must be signed in to change notification settings - Fork 412
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add missing template functionality to lifecycle_node. (#707)
* Add missing template functionality to lifecycle_node. Recent changes to the node_parameters interface was accompanied by additions to the node.hpp header and implementation files. However, these additions were not also made to the corresponding lifecycle node files. This PR includes the changes required for the lifecycle node. Going forward, I suggest that any code like this that supplements the basic node interfaces should either be factored out into a separate header that both node and lifecycle_node include, or that the supplemental code simply be included in the appropriate node_interface file directly, if possible. That way we can avoid code duplication and its symptoms which is node and lifecycle_node getting out of sync (which they have several times). Signed-off-by: Michael Jeronimo <michael.jeronimo@intel.com> * consolidate documentation to just be in rclcpp/node.hpp Signed-off-by: William Woodall <william@osrfoundation.org> * fix visibility macros Signed-off-by: William Woodall <william@osrfoundation.org> * deprecation methods that were also deprecated in rclcpp::Node Signed-off-by: William Woodall <william@osrfoundation.org> * fixup variable name Signed-off-by: William Woodall <william@osrfoundation.org> * add missing template method implementations Signed-off-by: William Woodall <william@osrfoundation.org> * add more methods that were not ported to lifecycle node originally Signed-off-by: William Woodall <william@osrfoundation.org> * fix cpplint Signed-off-by: William Woodall <william@osrfoundation.org>
- Loading branch information
Showing
4 changed files
with
267 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.