Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: William Woodall <william+github@osrfoundation.org>
  • Loading branch information
fujitatomoya and wjwwood committed Apr 23, 2020
1 parent 7150067 commit 20755c1
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class SubscriptionTopicStatistics

/// Handle a message received by the subscription to collect statistics.
/**
* - This method acquires a lock to prevent race conditions to collectors list.
* This method acquires a lock to prevent race conditions to collectors list.
*
* \param received_message the message received by the subscription
* \param now_nanoseconds current time in nanoseconds
Expand All @@ -120,7 +120,7 @@ class SubscriptionTopicStatistics

/// Publish a populated MetricsStatisticsMessage.
/**
* - This method acquires a lock to prevent race conditions to collectors list.
* This method acquires a lock to prevent race conditions to collectors list.
*/
virtual void publish_message()
{
Expand Down Expand Up @@ -152,7 +152,7 @@ class SubscriptionTopicStatistics
protected:
/// Return a vector of all the currently collected data.
/**
* - This method acquires a lock to prevent race conditions to collectors list.
* This method acquires a lock to prevent race conditions to collectors list.
*
* \return a vector of all the collected data
*/
Expand All @@ -169,7 +169,7 @@ class SubscriptionTopicStatistics
private:
/// Construct and start all collectors and set window_start_.
/**
* - This method acquires a lock to prevent race conditions to collectors list.
* This method acquires a lock to prevent race conditions to collectors list.
*/
void bring_up()
{
Expand All @@ -185,7 +185,7 @@ class SubscriptionTopicStatistics

/// Stop all collectors, clear measurements, stop publishing timer, and reset publisher.
/**
* - This method acquires a lock to prevent race conditions to collectors list.
* This method acquires a lock to prevent race conditions to collectors list.
*/
void tear_down()
{
Expand Down

0 comments on commit 20755c1

Please sign in to comment.