fix TestServerGoalHandle.cancel unit test

Signed-off-by: Kaven Yau <kavenyau@foxmail.com>
ros2 · Apr 26, 2021 · 39b0bdc · 39b0bdc
1 parent 07bef7b
commit 39b0bdc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rclcpp_action/test/test_server_goal_handle.cpp b/rclcpp_action/test/test_server_goal_handle.cpp
@@ -44,7 +44,7 @@ class FibonacciServerGoalHandle
 
   bool try_cancel() {return try_canceling();}
 
-  void cancel_goal() {_cancel_goal();}
+  bool cancel_goal() {return _cancel_goal();}
 };
 
 class TestServerGoalHandle : public ::testing::Test
@@ -110,7 +110,7 @@ TEST_F(TestServerGoalHandle, cancel) {
     auto mock_is_cancelable = mocking_utils::patch_and_return(
       "lib:rclcpp_action", rcl_action_goal_handle_is_cancelable, true);
     EXPECT_FALSE(handle_->try_cancel());
-    EXPECT_THROW(handle_->cancel_goal(), rclcpp::exceptions::RCLError);
+    EXPECT_FALSE(handle_->cancel_goal());
 
     test_msgs::action::Fibonacci::Result::SharedPtr result =
       std::make_shared<test_msgs::action::Fibonacci::Result>();