use universal reference to support rvalue. (#1883)

* use universal reference to support rvalue. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
ros2 · Feb 10, 2022 · 4c8cfa3 · 4c8cfa3
1 parent 891fff0
commit 4c8cfa3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/rclcpp/include/rclcpp/create_publisher.hpp b/rclcpp/include/rclcpp/create_publisher.hpp
@@ -92,7 +92,7 @@ template<
   typename NodeT>
 std::shared_ptr<PublisherT>
 create_publisher(
-  NodeT & node,
+  NodeT && node,
   const std::string & topic_name,
   const rclcpp::QoS & qos,
   const rclcpp::PublisherOptionsWithAllocator<AllocatorT> & options = (

diff --git a/rclcpp/test/rclcpp/test_publisher.cpp b/rclcpp/test/rclcpp/test_publisher.cpp
@@ -156,6 +156,17 @@ TEST_F(TestPublisher, various_creation_signatures) {
       rclcpp::create_publisher<Empty>(node, "topic", 42, options);
     (void)publisher;
   }
+  {
+    auto publisher = rclcpp::create_publisher<Empty>(
+      node->get_node_topics_interface(), "topic", 42, rclcpp::PublisherOptions());
+    (void)publisher;
+  }
+  {
+    auto node_topics_interface = node->get_node_topics_interface();
+    auto publisher = rclcpp::create_publisher<Empty>(
+      node_topics_interface, "topic", 42, rclcpp::PublisherOptions());
+    (void)publisher;
+  }
   {
     auto node_parameters = node->get_node_parameters_interface();
     auto node_topics = node->get_node_topics_interface();