Skip to content

Commit

Permalink
Link to ticket re rcl_yaml_param_parser avoiding circular dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
dhood committed Sep 14, 2018
1 parent b1af280 commit 80595f3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ NodeParameters::NodeParameters(
std::map<std::string, rclcpp::Parameter> parameters;

// TODO(sloretz) use rcl to parse yaml when circular dependency is solved
// See https://github.com/ros2/rcl/issues/252
for (const std::string & yaml_path : yaml_paths) {
rcl_params_t * yaml_params = rcl_yaml_node_struct_init(options->allocator);
if (nullptr == yaml_params) {
Expand Down

0 comments on commit 80595f3

Please sign in to comment.