Skip to content

Commit

Permalink
rclcpp_action removed rosidl_generator_cpp and rosidl_generator_c dep…
Browse files Browse the repository at this point in the history
…endencies
  • Loading branch information
ahcorde committed Feb 14, 2020
1 parent 7c1721a commit f52a5f0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
6 changes: 1 addition & 5 deletions rclcpp_action/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ find_package(ament_cmake_ros REQUIRED)
find_package(action_msgs REQUIRED)
find_package(rclcpp REQUIRED)
find_package(rcl_action REQUIRED)
find_package(rosidl_generator_cpp REQUIRED)

# Default to C++14
if(NOT CMAKE_CXX_STANDARD)
Expand All @@ -33,8 +32,7 @@ ament_target_dependencies(${PROJECT_NAME}
"action_msgs"
"rcl_action"
"rclcpp"
"rosidl_generator_c"
"rosidl_generator_cpp")
)

# Causes the visibility macros to use dllexport rather than dllimport,
# which is appropriate when building the dll but not consuming it.
Expand All @@ -60,8 +58,6 @@ ament_export_dependencies(ament_cmake)
ament_export_dependencies(action_msgs)
ament_export_dependencies(rclcpp)
ament_export_dependencies(rcl_action)
ament_export_dependencies(rosidl_generator_c)
ament_export_dependencies(rosidl_generator_cpp)

if(BUILD_TESTING)
find_package(ament_cmake_gtest REQUIRED)
Expand Down
6 changes: 0 additions & 6 deletions rclcpp_action/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@

<buildtool_depend>ament_cmake_ros</buildtool_depend>

<build_export_depend>rosidl_generator_cpp</build_export_depend>
<build_export_depend>rosidl_generator_c</build_export_depend>

<build_depend>rosidl_generator_c</build_depend>
<build_depend>rosidl_generator_cpp</build_depend>

<depend>action_msgs</depend>
<depend>rclcpp</depend>
<depend>rcl_action</depend>
Expand Down

0 comments on commit f52a5f0

Please sign in to comment.