Increasing test coverage of rclcpp_action #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2020
ahcorde
requested changes
Apr 8, 2020
|
@ahcorde ping for review |
ahcorde
requested changes
Apr 17, 2020
There was a problem hiding this comment.
see this comment https://github.com/ros2/rclcpp/pull/1043/files#r410073208
brawner
force-pushed
the
tests_rclcpp_action
branch
from
91dedaf
to
e823c67
Compare
|
Rebased and addressed feedback @ahcorde
|
ahcorde
approved these changes
Apr 22, 2020
|
In windows CI test_types is passing but in the result I see this error: |
|
I'm not sure what the error that fingerprinting error relates to, but the ci_windows build was marked because I used the wrong unsigned type in the test_types.cpp file. I've fixed that, running the tests again.
|
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
tests_rclcpp_action
branch
from
d3ac7f3
to
1550fae
Compare
|
Rebasing this branch and my ros2.repos file.
|
Signed-off-by: Stephen Brawner <brawner@gmail.com>
…tests_rclcpp_action
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
tests_rclcpp_action
branch
from
24fd179
to
5f9c5cb
Compare
|
Updating to fix deprecation warning.
|
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
* Increasing test coverage of rclcpp_action Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Increasing test coverage of rclcpp_action Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix warnings Signed-off-by: Stephen Brawner <brawner@gmail.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Set to list: writer_choices: record.py Signed-off-by: EsipovPA <esipov.p@mail.ru> * Set to list: storage_choices: reindex.py Signed-off-by: EsipovPA <esipov.p@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to bring the rclcpp packages up to Quality Level 1, this introduces many more tests of the rclcpp_action api. This brings the coverage from 76% to 83% of the
srcfiles and 94% of theincludefiles (87% combined).Signed-off-by: Stephen Brawner brawner@gmail.com