-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing test coverage of rclcpp_components #1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes lgtm
0bd1fa4
to
c4a409e
Compare
@ahcorde ping for review |
c4a409e
to
2cc0379
Compare
Rebasing on master and removing the dependency on #1043 |
aarch-64 doesn't like my constructor throws exception test. I'll need to look into this one more. |
6fcdf78
to
3ea66c3
Compare
Signed-off-by: Stephen Brawner <brawner@gmail.com>
osX warnings exist already in nightlies. Also, build.ros2.org failure is not related and already existid prior to this PR. |
* Increasing test coverage of rclcpp_components Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fixup Signed-off-by: Stephen Brawner <brawner@gmail.com> * Removing throws test for now Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Set to list: writer_choices: record.py Signed-off-by: EsipovPA <esipov.p@mail.ru> * Set to list: storage_choices: reindex.py Signed-off-by: EsipovPA <esipov.p@mail.ru>
Similar to #1043, this adds tests to increase the test coverage of rclcpp_components as part of the effort to bring it to QL 1. This additions bring the coverage from 88% to 100% of the
include
files and 95% of thesrc
files (96% combined).Depends on #1043
New commit: 85193e6