Increasing test coverage rclcpp_lifecycle #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
reviewed
Apr 29, 2020
rclcpp_action/CMakeLists.txt
Outdated
| @@ -98,6 +98,16 @@ if(BUILD_TESTING) | |||
| ${PROJECT_NAME} | |||
| ) | |||
| endif() | |||
|
|
|||
There was a problem hiding this comment.
this PR also adds a lot of tests for rclcpp_action, were those added intentionally here?
Seems that the same tests were added in #1043
rclcpp_components/CMakeLists.txt
Outdated
| set(components "${components}test_rclcpp_components::TestComponentThrows;$<TARGET_FILE:test_component>\n") | ||
|
|
||
| # Used to catch invalid resource entry | ||
| set(invalid_components "test_rclcpp_components::TestComponentFoo;;$<TARGET_FILE:test_component>\n") |
There was a problem hiding this comment.
Same about adding tests to rclcpp_components, sounds like a duplicate of #1044.
|
@ivanpauno Because there was a lot of files added in these PRs, I broke them out into three different ones stacked on top of one another. There is no reason why they should be dependent on one another. I'll clean that up. |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
tests_rclcpp_part1
branch
from
7441e1d
to
7926cc6
Compare
ahcorde
approved these changes
Apr 30, 2020
dirk-thomas
reviewed
Jun 26, 2020
|
|
||
| void TearDown() override | ||
| { | ||
| rclcpp::shutdown(); |
There was a problem hiding this comment.
Calling shutdown from a different thread causes a race which was making this test fail in the nightly jobs since it has been added. See #1204 for the proposed fix.
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #1043 and #1044, this PR increases the test coverage for rclcpp_lifecycle. The test coverage increases from 61% to 100% of the
includefiles and 87% of thesrcfiles (88% combined)Depends on #1043, #1044
New commit: 7441e1d