Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize rcl_handle to prevent leak (#1528) #1529

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

y-okumura-isp
Copy link
Contributor

Fixes #1528.

Signed-off-by: y-okumura-isp y-okumura@isp.co.jp

Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 963b5bb into ros2:master Jan 27, 2021
Karsten1987 pushed a commit that referenced this pull request Mar 2, 2021
Signed-off-by: y-okumura-isp <y-okumura@isp.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASAN error in rclcpp_action test_goal_handle
3 participants