Remove unused on_parameters_set_callback_ #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolai Morin <nikolai.morin@apex.ai>
fujitatomoya
reviewed
Jun 8, 2022
There was a problem hiding this comment.
the change looks good to me.
#772 allows it to register multiple on_parameters_set_callback.
I am not sure why on_parameters_set_callback_ is removed at the same time...
@ivanpauno any thoughts?
|
Looks good to me. |
|
CI:
|
There was a tick-tock cycle. |
|
Thanks @nnmm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could be wrong, but this callback seems to be obsolete – there is no way to set it through the public API.