Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make create_service accept rclcpp::QoS #1969

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Make create_service accept rclcpp::QoS #1969

merged 1 commit into from
Jul 12, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 11, 2022

Follow up to #1964, this allows using rclcpp::QoS with create_service and deprecates the version taking rmw_qos_profile_t

@sloretz
Make create_service accept rclcpp::QoS
20b8238 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the enhancement New feature or request label Jul 11, 2022
@sloretz sloretz self-assigned this Jul 11, 2022
@sloretz sloretz mentioned this pull request Jul 11, 2022
Merged
@sloretz
Copy link
Contributor Author

sloretz commented Jul 11, 2022

CI (build: --packages-above-and-dependencies rclcpp rclcpp_lifecycle test: --packages-select rclcpp rclcpp_lifecycle test_rclcpp test_quality_of_service)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

@sloretz i will go ahead to merge this since we have green on CI.

@fujitatomoya fujitatomoya merged commit 64e4c72 into rolling Jul 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__create_service_qos branch July 12, 2022 00:41
@sloretz
Copy link
Contributor Author

sloretz commented Jul 12, 2022

@fujitatomoya I'll assume your approval is good for ros2/system_tests#507 and merge that one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@sloretz sloretz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sloretz @fujitatomoya