Topic node guard condition in executor #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 1, 2023 13:21
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
|
@iuhilnehc-ynos can you start CI? |
|
CI: (build:
|
|
Looks good to me. |
alsora
approved these changes
Jan 24, 2023
|
I'm merging this PR, since it has green CI and approvals. |
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Feb 10, 2023
* add a test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rollback the node guard condition for exectuor Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
@alsora thanks for checking on this. |
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
* add a test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rollback the node guard condition for exectuor Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
* add a test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rollback the node guard condition for exectuor Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
* add a test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rollback the node guard condition for exectuor Signed-off-by: Chen Lihui <lihui.chen@sony.com> --------- Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #2067