Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Logger::get_effective_level(). #2141

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

fujitatomoya
Copy link
Collaborator

@clalancette @iuhilnehc-ynos could you do review when you have time?

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Mar 28, 2023
@fujitatomoya fujitatomoya added the enhancement New feature or request label Mar 28, 2023
Copy link
Collaborator

@iuhilnehc-ynos iuhilnehc-ynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions

rclcpp/include/rclcpp/logger.hpp Show resolved Hide resolved
rclcpp/test/rclcpp/test_logger.cpp Show resolved Hide resolved
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

  • Linux-aarch64 Build Status

@fujitatomoya
Copy link
Collaborator Author

@clalancette i will go ahead to merge this.

@fujitatomoya fujitatomoya merged commit a5368e6 into rolling Mar 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/20230327-get-effective-level branch March 30, 2023 04:50
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants