Use the same context for the specified node in rclcpp::spin functions #2433
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
HansRobo
force-pushed
the
fix/spin_xx_with_context
branch
from
7cf56a9
to
d56c99f
Compare
HansRobo
changed the title
|
The approach in the PR looks good to me. There's several test failures. We should also add a unit-test to verify that the executor is using the correct context |
fujitatomoya
approved these changes
Feb 29, 2024
|
@HansRobo FYI, the feature freeze for Jazzy will be in ~2 weeks, would you be able to add tests before that date? |
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
fujitatomoya
reviewed
Apr 5, 2024
|
@HansRobo thanks for adding test, i have a question for test. |
|
@alsora since you are interested in this PR. can you take a look at this? i will leave this to you. |
|
https://build.ros2.org/job/Rpr__rclcpp__ubuntu_noble_amd64/106/ is unrelated failure. |
alsora
approved these changes
Apr 5, 2024
|
|
Merging with green full CI (the github action failure is unrelated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rclcpp::spin functions,
rclcpp::spin,rclcpp::spin_some, and so on, use the default context.However they may occur errors when you use the custom context for the specified node of argument of spin functions.
In this pull-request, I set in-place executor to use context of node via executor options.
This is the only fix I found, but there may be other similar fixes.