Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compare-function-pointers in test_utilities #2489

Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 5, 2024

Related with this issue #2488

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 5, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to the wording, then I'm on board with this.

rclcpp/test/rclcpp/test_utilities.cpp Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from clalancette April 5, 2024 15:09
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 5, 2024

  • Linux clang Build Status
  • Linux-aarch64 clang Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 5, 2024

other warning are unrelated

@ahcorde ahcorde merged commit fa59680 into rolling Apr 5, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rolling/disable_compare_function_warn_test_utilities branch April 5, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants