Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup var names to snake case #2501

Merged
merged 2 commits into from Apr 12, 2024
Merged

fixup var names to snake case #2501

merged 2 commits into from Apr 12, 2024

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Apr 12, 2024

Follow up to #2343

@wjwwood
dataPtr -> data_ptr
e79afbf 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
remove incorrect trailing _
dedeb29 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood requested a review from mjcarroll April 12, 2024 12:52
@wjwwood wjwwood self-assigned this Apr 12, 2024
@wjwwood wjwwood mentioned this pull request Apr 12, 2024
Merged
@mjcarroll
Copy link
Member

CI just up to rclcpp

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit dec22a2 into rolling Apr 12, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the wjwwood/fixup_var_names_to_snake_case branch April 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@jmachowinski jmachowinski jmachowinski approved these changes

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjwwood @mjcarroll @jmachowinski