pass AnyExecutable objects as reference to avoid memory allocation #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
approved these changes
Apr 17, 2018
rclcpp/src/rclcpp/executor.cpp
Outdated
| if (any_exec) { | ||
| RCLCPP_SCOPE_EXIT({ | ||
| this->spinning.store(false); | ||
| }); |
There was a problem hiding this comment.
Just curious, is this a bug fix or style fix? It looks like the macro already adds {} around its arguments.
There was a problem hiding this comment.
For consistency, there's another use of the scope exit macro on line 208 that could have {} added to it.
There was a problem hiding this comment.
I'll remove this diff and maybe make a separate pr for this change then, since its growing in scope :)
|
The style undo is net zero diff, and the Windows warning is a false positive, so I'll merge as-is. |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Use foxy testing apt repos to install linters for Actions Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been trying to eliminate steady-state memory allocation, and this was identified as one of the easiest things we could change to avoid an unnecessary memory allocation and customization point.
CI: