Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rosgraph_msgs/Clock for /clock topic. #474

Merged
merged 2 commits into from
May 30, 2018
Merged

Use rosgraph_msgs/Clock for /clock topic. #474

merged 2 commits into from
May 30, 2018

Conversation

ernestmc
Copy link
Member

@ernestmc ernestmc commented May 16, 2018 •
edited by mikaelarguedas
Loading

Addresses issue #473
Use rosgraph_msgs/Clock message for /clock topic instead of builtin_interfaces/Time to be compatible with ROS1.
This is needed for the ros1_bridge to effectively map /clock message when using Gazebo.

connects to #473

@ernestmc ernestmc added the in progress Actively being worked on (Kanban column) label May 16, 2018
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels May 17, 2018
@mikaelarguedas
Copy link
Member

@ernestmc Thanks for the patch! We assumed this is ready for review so we labeled it as is (please comment here if this is not the case)
Tip: We also modified the description to connect to the relevant issue so that they are displayed together on the waffle board

@ernestmc
Copy link
Member Author

@mikaelarguedas this is ready for review. I've tested and it works. Awaiting you comments.

@mikaelarguedas
Copy link
Member

@ernestmc It looks like this PR makes multiple rclcpp tests fail.
Can you confirm if you have the same failures on your side ? (you can run the tests of a package by using ament test --only <PKG_NAME>)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) requires-changes and removed in review Waiting for review (Kanban column) labels May 18, 2018
@ernestmc
Copy link
Member Author

Forgot to try the tests. I'll look at them and let you know.

@ernestmc
Copy link
Member Author

@mikaelarguedas I've updated the test cases and now they are passing.

100% tests passed, 0 tests failed out of 27

Label Time Summary:
copyright     =   0.77 sec (1 test)
cppcheck      =   0.87 sec (1 test)
cpplint       =   5.72 sec (1 test)
gmock         =   0.23 sec (1 test)
gtest         =   7.29 sec (21 tests)
lint_cmake    =   0.70 sec (1 test)
linter        =  10.35 sec (5 tests)
uncrustify    =   2.28 sec (1 test)

@mikaelarguedas
Copy link
Member

mikaelarguedas commented May 29, 2018 •
edited
Loading

thanks @ernestmc

  • Linux Build Status
  • Linux-aarch64: cancelled
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) requires-changes labels May 29, 2018
@mikaelarguedas
Copy link
Member

mikaelarguedas commented May 29, 2018 •
edited
Loading

@ernestmc FYI: I rebased this branch on top of master and force pushed it

The reason:
Our ci is unable to merge branches from forks at the moment and severals tests are failing due to the outdated state of this branch.

In the future we recommend, when possible, opening PRs from branches hosted on the ros2 repositories this way CI will make sure to merge your branch into master before building.

New round of CI on rebased branch:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ernestmc
Copy link
Member Author

Thanks @mikaelarguedas . I've rebased my branch to keep it updated. I didn't know if I could push a new branch directly into the repo.

@mikaelarguedas
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

mikaelarguedas
mikaelarguedas approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks good to me.

I leave it up to @tfoote to give final review/approval

mikaelarguedas
mikaelarguedas reviewed May 30, 2018
View reviewed changes
rclcpp/test/test_time_source.cpp
clock_pub->publish(msg);
// std::cout << "Publishing: '" << msg->sec << ".000000" << msg->nanosec << "'" << std::endl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfoote did you want to keep these for debugging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to keep those lines I need to update them to the new message type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't need to keep them.

@dirk-thomas dirk-thomas requested a review from tfoote May 30, 2018 17:11
tfoote
tfoote approved these changes May 30, 2018
View reviewed changes
rclcpp/test/test_time_source.cpp
clock_pub->publish(msg);
// std::cout << "Publishing: '" << msg->sec << ".000000" << msg->nanosec << "'" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't need to keep them.

@mikaelarguedas
Copy link
Member

thanks @ernestmc for the contribution and @tfoote for the second round of review, merging..

@mikaelarguedas mikaelarguedas merged commit d605727 into ros2:master May 30, 2018
@dirk-thomas dirk-thomas mentioned this pull request May 31, 2018
Closed
@tfoote tfoote mentioned this pull request Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ernestmc @mikaelarguedas @tfoote