Spin before checking if ros time is active #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
approved these changes
May 30, 2018
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
…s2#483) * Support rcl_params_t copies. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Parse parameter overrides from command line. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Parameter overrides' tests passing. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Test rcl_yaml_node_struct_copy() function Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Export rcl_yaml_param_parser as rcl dependency. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Zero initialize parameter overrides before rcl arguments copy. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Initialize local variables early enough. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Simplify rcl package.xml Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Assert arguments sanity in rcl args parsing internal functions. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Extend rcl_yaml_param_parser tests to all parameter types. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Address peer review comments. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Support --remap/-r flags. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Please cpplint Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* add negative check to init py Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add unit test Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify unit test Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * revert test_play Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * typo string to int Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add history value to unit tests Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add validation to duration keys Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify duration validation Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify duration validation Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify comparison Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify style Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify style Signed-off-by: Jesse Ikawa <jikawa@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a possible cause of a test failure described by this comment.
During the test the
ros_clock->ros_time_is_active()method is expected to return false, but sometimes it returns true. "Ros Time" on a clock is activated or deactivated in a subscription callback on theparameter_eventstopic. ASyncParametersClientcallsspin_node_until_future_completewith anstd::shared_futurethat completes when a response to a request to set parameters has been received. It looks like it is possible for the client response to be received before theparameter_eventssubscription callback is called.Without this PR I see a test failure on my ubuntu xenial machine ~50% of the time using
--retest-until-fail 100. With this PR--retest-until-fail 1800completed without failing.I don't know why the change in #478 made this test flaky.
CI (only test rclcpp since only code change is in a test)