Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing set_parameters_atomically client #494

Merged
merged 1 commit into from
Jun 11, 2018
Merged

add missing set_parameters_atomically client #494

merged 1 commit into from
Jun 11, 2018

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Jun 8, 2018 •
edited
Loading

The parameter server creates the following service servers:

describe_parameters
get_parameters
get_parameter_types
list_parameters,
set_parameters
set_parameters_atomically

The parameter client creates all but set_parameters_atomically.

Is it intentional ?

Assuming it's not, this PR adds the missing one.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Leaving this in progress until CI comes back green

@mikaelarguedas mikaelarguedas self-assigned this Jun 8, 2018
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Jun 8, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 8, 2018
Merged
@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 8, 2018
tfoote
tfoote approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, in early generations I believe there was discussion of only allowing atomic operations locally etc, but if we have the server side we should definitely have the client available.

@mikaelarguedas mikaelarguedas merged commit 1b87970 into master Jun 11, 2018
@mikaelarguedas mikaelarguedas deleted the param_client_set_atomically branch June 11, 2018 23:53
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 11, 2018
@ruffsl ruffsl mentioned this pull request Aug 15, 2018
Closed
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@pjreed @hidmic
Treat __name the same as __node (ros2#494)
8af6f17 
* Treat __name the same as __node

This modifies the lexer so that it will accept __name and treat it
exactly the same as __node.  __node still works in order to preserve
backwards compatibility.

Fixes ros2#258

Distribution Statement A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>

* Update dot graph for lexer

Distribution Statement A; OPSEC #2893

Signed-off-by: P. J. Reed <preed@swri.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikaelarguedas @tfoote @wjwwood