Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect exception on sec < 0 #527

Merged
merged 4 commits into from
Aug 9, 2018
Merged

Remove incorrect exception on sec < 0 #527

merged 4 commits into from
Aug 9, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 27, 2018 •
edited
Loading

Discussion in #525

This removes a thrown exception that appears to be a copy/paste error from rclcpp::Time.

Requires ros2/rcl_interfaces#38

@sloretz sloretz added the in review Waiting for review (Kanban column) label Jul 27, 2018
@sloretz sloretz self-assigned this Jul 27, 2018
@sloretz sloretz mentioned this pull request Jul 27, 2018
Closed
@sloretz
Copy link
Contributor Author

sloretz commented Jul 27, 2018

CI for this and ros2/rcl_interfaces#38

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

tfoote
tfoote previously approved these changes Jul 27, 2018
View reviewed changes
@sloretz sloretz added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Aug 1, 2018
@sloretz sloretz dismissed tfoote’s stale review August 1, 2018 19:08

Need to change test expectation with negative durations

@sloretz
Copy link
Contributor Author

sloretz commented Aug 1, 2018

CI (testing just rclcpp since only code throwing an exception was removed)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 1, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Aug 1, 2018 •
edited
Loading

CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
    • Test added by this PR fails, investigating

@sloretz sloretz added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Aug 1, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Aug 1, 2018

CI again

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Aug 1, 2018 •
edited
Loading

Another attempt at CI

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
    • Java traceback, rebuild: macOS Build Status
  • Windows Build Status

@sloretz sloretz added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 2, 2018
@sloretz sloretz merged commit 6b34bcc into master Aug 9, 2018
@sloretz sloretz deleted the negative_duration branch August 9, 2018 16:23
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Aug 9, 2018
@dhood dhood mentioned this pull request Aug 10, 2018
Open
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
@jaisontj
Remove some code duplication between SequentialWriter and SequentialC…
d745972 
…ompressionWriter (ros2#527)

Remove code duplication between SequentialWriter and SequentialCompressionWriter

Signed-off-by: Jaison Titus <jaisontj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@tfoote tfoote tfoote left review comments

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sloretz @wjwwood @tfoote