-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rclcpp_lifecycle] introduce new service for valid transitions to call #550
Comments
Beside the three PRs updating |
@Myzhar Do you mind having a look at this and let me know if this meets your expectations? I believe you have quite some experiences with the lifecycle implementation by now (given that you have been vocal about it on github and discourse). The set of patches (branch |
I will look at it with very pleasure and will let you know |
@Karsten1987 I need a few suggestion on how to update my workspace with the patches introduced with the |
so essentially you want to checkout the branches, right? So in your workspace you can run the following command to do so:
If not, you should be able to go into each referenced repository and change the git branch manually.
|
Ok, from Waffle I found the list of repositories that have been patched:
I launched a [Update: I received your previous comment while I was writing mine] I modified the code of my node to follow the new returns type and the other modifications and I finally noticed that the command: This is also a very useful command:
I tried also to understand what kind of other modifications you have introduced, to see if I can get enhancements at code level, but it's not easy. |
We do have the code review, so don't worry too much about that. It was more like to ask whether that gives you a solution to the issue you posted on discourse. |
What I have not understood is if now it is possible to change state internally calling a transition. To be more clear I explain my use case: This is how I understood the way of working with the Lifecycle node... if I'm right. |
So from what I understand is that you want to shutdown the camera either when Nevertheless, I am going to merge this then as it seems to fulfill the requirements described in your discourse post. |
see discourse discussion here: https://answers.ros.org/question/302402/ros2cli-lifecycle-shutdown-transition/
The text was updated successfully, but these errors were encountered: