Asign node path name and time stamp to parameter event message #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR together with rcl_interfaces PR 51 works like a charm for my use-case (rclcpp-based monitoring of the system-wide configuration / node parameters). |
|
Generally this looks good. There appears to be a conflict with the recently added waitable interfaces. If you have a moment to check that it would be great. Then I can run CI on this and the python version. |
modify adding clock for rclcpp_lifestyle
bpwilcox
force-pushed
the
add_node_info_events
branch
from
ce040e9
to
45201e6
Compare
|
@tfoote I fixed the conflicts. It builds fine on my machine. |
tfoote
approved these changes
Dec 4, 2018
dirk-thomas
reviewed
Dec 5, 2018
| node_graph_, | ||
| node_services_, | ||
| node_logging_ | ||
| )), |
There was a problem hiding this comment.
This line has trailing white spaces. @tfoote Please run the unit tests before merging PRs.
There was a problem hiding this comment.
Thanks @dirk-thomas I'm not sure how that passed. I ran CI here: ros2/rcl_interfaces#51 (comment)
dirk-thomas
added a commit
that referenced
this pull request
Dec 5, 2018
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
modify adding clock for rclcpp_lifestyle
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rcl_interfaces#51
This PR follows my pull request in rcl_interfaces: ros2/rcl_interfaces#51 which adds a node name field and timestamp field to the ParameterEvents.msg. This pull request fills those fields.