overload for node interfaces #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
CI:
|
wjwwood
approved these changes
Apr 17, 2019
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
Sorry @wjwwood, I've noticed too late that the action client follows the same principle. Hence, I've modified the PR for the client as well. new round of CI:
|
wjwwood
approved these changes
Apr 17, 2019
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
* overload for node interfaces Signed-off-by: Karsten Knese <karsten@openrobotics.org> * remove new line Signed-off-by: Karsten Knese <karsten@openrobotics.org> * overload client for node iterfaces Signed-off-by: Karsten Knese <karsten@openrobotics.org>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Add time conversion logic diagrams to time control design Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #699
This PR allows to create an action server within a constructor inheriting from node and therefore composition of these nodes.
Signed-off-by: Karsten Knese karsten@openrobotics.org