Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_actual_qos should return an rclcpp::QoS rather than an rmw_qos_profile_t #859

Closed
wjwwood opened this issue Sep 19, 2019 · 1 comment · Fixed by #883
Closed

get_actual_qos should return an rclcpp::QoS rather than an rmw_qos_profile_t #859

wjwwood opened this issue Sep 19, 2019 · 1 comment · Fixed by #883
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wjwwood
Copy link
Member

wjwwood commented Sep 19, 2019

Introduced to the Publisher class in #667, this function really ought to return the rclcpp version of the QoS. Users can always use these methods on the rclcpp::QoS class to get the rmw profile still:

/// Return the rmw qos profile.
rmw_qos_profile_t &
get_rmw_qos_profile();
/// Return the rmw qos profile.
const rmw_qos_profile_t &
get_rmw_qos_profile() const;

@wjwwood wjwwood added enhancement New feature or request help wanted Extra attention is needed labels Sep 19, 2019
@wjwwood
Copy link
Member Author

wjwwood commented Sep 19, 2019

I'm not sure if we should tick-tock this or just change it directly. I don't think it needs to be backported either way.

nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
* fix test_info_by_topic flaky using GraphCache interface

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant