Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rclcpp_action] Do not throw exception in action client if take fails #888

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[rclcpp_action] Do not throw exception in action client if take fails #888

merged 1 commit into from
Oct 14, 2019

Conversation

jacobperron
Copy link
Member

Fixes #886

As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that an error occurred.

@jacobperron
[rclcpp_action] Do not throw exception in action client if take fails
dffba78 
As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@wuffle-ros wuffle-ros bot added the in review Waiting for review (Kanban column) label Oct 11, 2019
@jacobperron jacobperron mentioned this pull request Oct 11, 2019
Closed
@jacobperron
Copy link
Member Author

jacobperron commented Oct 11, 2019 •
edited
Loading

Testing dependencies of rclcpp_action:

  • LinuxBuild Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: test communication failures also happened in the latest nightlies.

@jacobperron jacobperron mentioned this pull request Oct 11, 2019
Closed
@jacobperron jacobperron merged commit 8e69b7d into master Oct 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/handle_non_error_rc branch October 14, 2019 16:04
jacobperron added a commit that referenced this pull request Oct 14, 2019
@jacobperron
[rclcpp_action] Do not throw exception in action client if take fails (…
e148700 
…#888)

As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Oct 14, 2019
Merged
jacobperron added a commit that referenced this pull request Oct 24, 2019
@jacobperron
[rclcpp_action] Do not throw exception in action client if take fails (…
8f440ea 
…#888)

As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Oct 24, 2019
Merged
jacobperron added a commit that referenced this pull request Nov 18, 2019
@jacobperron
[rclcpp_action] Do not throw exception in action client if take fails (…
82f6dfa 
…#888) (#891)

As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Nov 26, 2019
@jacobperron
[rclcpp_action] Do not throw exception in action client if take fails (…
05a8e5c 
…#888) (#905)

As documented in rcl_action, a return code of RCL_RET_ACTION_CLIENT_TAKE_FAILED does not mean that
an error occurred.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
in review Waiting for review (Kanban column)
Projects
No open projects
Dashing Patch Release 4
Proposed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action executor doesn't allow spurious client wakeup
2 participants
@jacobperron @dirk-thomas