Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure domain_id via InitOptions. #1165

Merged
merged 11 commits into from
Aug 5, 2020
Merged

Ability to configure domain_id via InitOptions. #1165

merged 11 commits into from
Aug 5, 2020

Commits on Aug 4, 2020

  1. Ability to configure domain_id via InitOptions. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    51f24eb View commit details
    Browse the repository at this point in the history

  2. use rcl_init_options_set/get_domain_id. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    8fef12e View commit details
    Browse the repository at this point in the history

  3. use rcl_get_default_domain_id() instead. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    259c369 View commit details
    Browse the repository at this point in the history

  4. get rid of unnecessary headers and fix comments. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    42ebba8 View commit details
    Browse the repository at this point in the history

  5. use RCL_DEFAULT_DOMAIN_ID as default value. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    d2630e6 View commit details
    Browse the repository at this point in the history

  6. protect init_options_ with mutex. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    8563ea0 View commit details
    Browse the repository at this point in the history

  7. add test for InitOptions. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    65b01de View commit details
    Browse the repository at this point in the history

  8. Delete mutex lock from InitOptions constructor. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    46d65d3 View commit details
    Browse the repository at this point in the history

  9. use std::mutex instead of std::recursive_mutex. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    14693dc View commit details
    Browse the repository at this point in the history

  10. get rid of unrelated changes. 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    cea62b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. fix test_domain_id to call rcl_get_default_domain_id(). 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    3005803 View commit details
    Browse the repository at this point in the history