Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding callback groups in executor #1218

Merged
merged 79 commits into from
Sep 2, 2020
Merged

Adding callback groups in executor #1218

merged 79 commits into from
Sep 2, 2020

Commits on Aug 21, 2020

  1. Initial version of callback-group-based Executor. 

    Signed-off-by: Ralph Lange <ralph.lange@de.bosch.com>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @ralph-lange @peterpena
    ralph-lange authored and peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e5775b5 View commit details
    Browse the repository at this point in the history

  2. removed RealTimeClass 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    a5ced60 View commit details
    Browse the repository at this point in the history

  3. can add multiple cbgs and check if callback is owned by another exec … 

    …before adding

Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8a014d8 View commit details
    Browse the repository at this point in the history

  4. cbg var for option to add to executor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    3bea373 View commit details
    Browse the repository at this point in the history

  5. getter for callback groups in executor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8145a3f View commit details
    Browse the repository at this point in the history

  6. test 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    6241e4d View commit details
    Browse the repository at this point in the history

  7. add many nodes and callback groups together 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    00bef4b View commit details
    Browse the repository at this point in the history

  8. test for map of callback groups and nodes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    a8b2f88 View commit details
    Browse the repository at this point in the history

  9. added a test for map and callback group duplication 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    547f977 View commit details
    Browse the repository at this point in the history

  10. add cbg that are not assign and allow to do so, only iterate through … 

    …groups in maps

Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4b1dac8 View commit details
    Browse the repository at this point in the history

  11. memory strat should only add handles that belong to it 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    321cd92 View commit details
    Browse the repository at this point in the history

  12. fixed executor deconstructor seg fault bug 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    89345cd View commit details
    Browse the repository at this point in the history

  13. fixed remove node and guard condition bug 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    bc75d3a View commit details
    Browse the repository at this point in the history

  14. fixed uncrustify 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    37af5f5 View commit details
    Browse the repository at this point in the history

  15. cpplint 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    d5f7d46 View commit details
    Browse the repository at this point in the history

  16. remove line break and add static executor in cmakelist 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    18b4d49 View commit details
    Browse the repository at this point in the history

  17. enabled static executor and added add callback group feature 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    fbe586f View commit details
    Browse the repository at this point in the history

  18. fixed test_allocator_memory_strategy 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    106ef99 View commit details
    Browse the repository at this point in the history

  19. test allocator 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    19216b5 View commit details
    Browse the repository at this point in the history

  20. test mem strat with cbg feat 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c2edc45 View commit details
    Browse the repository at this point in the history

  21. remove cbg in static executor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ac8f586 View commit details
    Browse the repository at this point in the history

  22. adapted guard conditions 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    db2532b View commit details
    Browse the repository at this point in the history

  23. collector deconstructor and remove cbg when remove node in static 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    76e4344 View commit details
    Browse the repository at this point in the history

  24. fixed invalid group ptr seg fault introduced in wait for work 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    649c800 View commit details
    Browse the repository at this point in the history

  25. passes the test allocator mem strat 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9795067 View commit details
    Browse the repository at this point in the history

  26. added weak node check in memory strategy; passes brawner unit tests 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    064e9e7 View commit details
    Browse the repository at this point in the history

  27. uncrustify for tests 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e3ae993 View commit details
    Browse the repository at this point in the history

  28. lint and uncrustify 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    356c2c1 View commit details
    Browse the repository at this point in the history

  29. exposed allowable state at the node level and added unit tests 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    89b9623 View commit details
    Browse the repository at this point in the history

  30. unit test to add one node mult executors 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    691b082 View commit details
    Browse the repository at this point in the history

  31. frixed allow executor reset bug 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4472e22 View commit details
    Browse the repository at this point in the history

  32. code block for callback group and executor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    0f9c68d View commit details
    Browse the repository at this point in the history

  33. add code block for add/remove cbg 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    d4b7e5a View commit details
    Browse the repository at this point in the history

  34. add comments for add/remove callback group 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    1adfc9e View commit details
    Browse the repository at this point in the history

  35. changed from atomic to const 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    be2cbce View commit details
    Browse the repository at this point in the history

  36. fixed test different cbgs for nodes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    72f308e View commit details
    Browse the repository at this point in the history

  37. lint 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e212773 View commit details
    Browse the repository at this point in the history

  38. added disabled nodes in services and map 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    cd96c57 View commit details
    Browse the repository at this point in the history

  39. changed var name to suggestion 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    d19866d View commit details
    Browse the repository at this point in the history

  40. comment for callback group constructor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9deb47d View commit details
    Browse the repository at this point in the history

  41. header ordering 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b46a9f0 View commit details
    Browse the repository at this point in the history

  42. Update rclcpp/include/rclcpp/executor.hpp 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8cde317 View commit details
    Browse the repository at this point in the history

  43. removed const ref and made protected 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9be482e View commit details
    Browse the repository at this point in the history

  44. removing internals in comments 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    0379c9e View commit details
    Browse the repository at this point in the history

  45. Apply suggestions from code review 

    general fixes

Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9f4cdd7 View commit details
    Browse the repository at this point in the history

  46. remove white space 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    7c702cc View commit details
    Browse the repository at this point in the history

  47. Apply suggestions from code review 

    general fix

Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5c2e03b View commit details
    Browse the repository at this point in the history

  48. fix comments 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    52aae7c View commit details
    Browse the repository at this point in the history

  49. Update rclcpp/include/rclcpp/executor.hpp 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    bf70092 View commit details
    Browse the repository at this point in the history

  50. fix comments 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    eefeca0 View commit details
    Browse the repository at this point in the history

  51. fix comments 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c987bb1 View commit details
    Browse the repository at this point in the history

  52. general fixes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c869f09 View commit details
    Browse the repository at this point in the history

  53. clang tidy and llvm deprecation and overriden fixes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9d6c989 View commit details
    Browse the repository at this point in the history

  54. made typedtests 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ced0aba View commit details
    Browse the repository at this point in the history

  55. add has callback method for static executor 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    6d12b11 View commit details
    Browse the repository at this point in the history

  56. removed map function and added comment about remove callback group 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    1edb8b9 View commit details
    Browse the repository at this point in the history

  57. adding two different data structures for add_node and add_callback_group 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e50a2b9 View commit details
    Browse the repository at this point in the history

  58. nitpick changes to documentation 

    Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @wjwwood @peterpena
    wjwwood authored and peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8a3e30d View commit details
    Browse the repository at this point in the history

  59. move implementation out of header 

    Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @wjwwood @peterpena
    wjwwood authored and peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    af3ca5e View commit details
    Browse the repository at this point in the history

  60. use const & 

    Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @wjwwood @peterpena
    wjwwood authored and peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    56da394 View commit details
    Browse the repository at this point in the history

  61. splitting add node and add cbg in static executro 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c6353a4 View commit details
    Browse the repository at this point in the history

  62. get cbgs for static executor and collector 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    546beec View commit details
    Browse the repository at this point in the history

  63. add weak nodes for nodes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    701fe00 View commit details
    Browse the repository at this point in the history

  64. get next ready executable with two maps 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    841a209 View commit details
    Browse the repository at this point in the history

  65. passes tests 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    b04b1b9 View commit details
    Browse the repository at this point in the history

  66. Apply suggestions from code review 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ec94f7e View commit details
    Browse the repository at this point in the history

  67. fixed has node function 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4a9244f View commit details
    Browse the repository at this point in the history

  68. fixed collect entities 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    e915c33 View commit details
    Browse the repository at this point in the history

  69. added unit tests for removal and added 3rd data struct 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    5c75d2e View commit details
    Browse the repository at this point in the history

  70. eliminated cbs vector 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9045be3 View commit details
    Browse the repository at this point in the history

  71. reusing same functions and added comments 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c43312e View commit details
    Browse the repository at this point in the history

  72. documentation, more exceptions, and name changes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    da4ea76 View commit details
    Browse the repository at this point in the history

  73. Apply suggestions from code review 

    changes for review

Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4657798 View commit details
    Browse the repository at this point in the history

  74. fixed deconstructor, first remove cbgs, then nodes 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    3ab9ad5 View commit details
    Browse the repository at this point in the history

  75. Apply suggestions from code review 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    ffbae58 View commit details
    Browse the repository at this point in the history

  76. fixed remove node issue 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    03bc30d View commit details
    Browse the repository at this point in the history

  77. throw an exception in remove node of collector 

    Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena
    peterpena committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9219986 View commit details
    Browse the repository at this point in the history

  78. Update rclcpp/include/rclcpp/executor.hpp 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    f6c1b53 View commit details
    Browse the repository at this point in the history

  79. Update rclcpp/include/rclcpp/executor.hpp 

    Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Pedro Pena <peter.a.pena@gmail.com>
    @peterpena @wjwwood
    peterpena and wjwwood committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c6772f5 View commit details
    Browse the repository at this point in the history