Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dashing) Add operator!= to Duration #1277

Merged
merged 1 commit into from
Aug 18, 2020
Merged

(dashing) Add operator!= to Duration #1277

merged 1 commit into from
Aug 18, 2020

Conversation

ivanpauno
Copy link
Member

Backports #1236.

This is an addition, not a bug fix.
It makes sense to me to backport this for consistency. It's weird to have all comparison operators except !=.

@ivanpauno
add operator!= for duration (#1236)
a966214 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Aug 14, 2020
@ivanpauno ivanpauno self-assigned this Aug 14, 2020
@ivanpauno ivanpauno mentioned this pull request Aug 14, 2020
Merged
audrow
audrow approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@audrow audrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the build passing.

@ivanpauno
Copy link
Member Author

@ros-pull-request-builder retest this please

@ivanpauno ivanpauno added this to Needs Backport in Dashing Patch Release 8 Aug 18, 2020
@ivanpauno ivanpauno moved this from Needs Backport to Needs Release in Dashing Patch Release 8 Aug 18, 2020
@ivanpauno ivanpauno merged commit c214ddc into dashing Aug 18, 2020
@ivanpauno
Copy link
Member Author

I clicked the squash-and-merge button. The merge failed and the PR was still open.
Some minutes after I clicked again, it worked.

The result, two commits (the second one with an empty diff):

Github is working quite well 😮

@ivanpauno ivanpauno deleted the ivanpauno/dashing-duration-neq branch August 18, 2020 13:38
@nuclearsandwich nuclearsandwich moved this from Needs Release to Released in Dashing Patch Release 8 Nov 25, 2020
iluetkeb pushed a commit to boschresearch/ros2_rclcpp that referenced this pull request May 4, 2021
@ivanpauno
add operator!= for duration (ros2#1236) (ros2#1277)
d27ca8e 
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jannik Abbenseth <ipa-jba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
No open projects
Dashing Patch Release 8
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivanpauno @audrow