Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string literal warnings #1442

Merged
merged 9 commits into from
Dec 18, 2020
Merged

Fix string literal warnings #1442

merged 9 commits into from
Dec 18, 2020

Commits on Dec 11, 2020

  1. Add warnings 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9e51873 View commit details
    Browse the repository at this point in the history

  2. Fix nonliteral string warnings 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    6bc4a6b View commit details
    Browse the repository at this point in the history

  3. Fix compile error from new logging functions in rclcpp_components 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    abd223e View commit details
    Browse the repository at this point in the history

  4. Use "%s" to make log string evaluation secure 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9cf60bd View commit details
    Browse the repository at this point in the history

  5. Fix logging warnings in rclcpp 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    96286cc View commit details
    Browse the repository at this point in the history

  6. Fix coding style to pass linter 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    6b8392d View commit details
    Browse the repository at this point in the history

  7. Get the c_str of streams 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    c632837 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Remove test to check string logging 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    774f72b View commit details
    Browse the repository at this point in the history

  2. Add in stream logging tests 

    Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
    @audrow
    audrow committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e71004c View commit details
    Browse the repository at this point in the history