Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goal response callback compatibility shim with deprecation of old signature #1495

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Goal response callback compatibility shim with deprecation of old signature #1495

merged 5 commits into from
Dec 21, 2020

Commits on Dec 18, 2020

  1. Goal response callback compatibility shim with deprecation of old sig… 

    …nature

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    58e25fb View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. No RCUTILS_LIKELY, no static_cast 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    d838e92 View commit details
    Browse the repository at this point in the history

  2. Make operator bool() explicit 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    8e9b87d View commit details
    Browse the repository at this point in the history

  3. linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    c20b9f0 View commit details
    Browse the repository at this point in the history

  4. Fix test error 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    476381b View commit details
    Browse the repository at this point in the history