Add tests for fixed-width integer function templates of declare_parameter #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter Signed-off-by: Nico Neumann <nico.neumann@iosb.fraunhofer.de>
Bi0T1N
force-pushed
the
function_template_declare_param
branch
from
a4abc51
to
1860816
Compare
wjwwood
reviewed
Aug 4, 2021
| node->declare_parameter<int32_t>(name5, 5); | ||
| node->declare_parameter<uint32_t>(name6, 5); | ||
| node->declare_parameter<int64_t>(name7, 5); | ||
| node->declare_parameter<uint64_t>(name8, 5); |
There was a problem hiding this comment.
As I mentioned in the other issue, I don't think this case can/should work.
Bi0T1N
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is related to #1743 but does not compile at the moment as discussed in the issue.