Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a case that not throw ParameterUninitializedException #2036

Merged
merged 5 commits into from
Nov 9, 2022
Merged

fix a case that not throw ParameterUninitializedException #2036

merged 5 commits into from
Nov 9, 2022

Commits on Nov 9, 2022

  1. fix a case that not throw ParameterUninitializedException 

    Signed-off-by: Chen Lihui <lihui.chen@sony.com>
    Chen Lihui committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5dac62c View commit details
    Browse the repository at this point in the history

  2. catch ParameterUninitializedException exception while calling get_par… 

    …ameters in service callback

Signed-off-by: Chen Lihui <lihui.chen@sony.com>
    Chen Lihui committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d117594 View commit details
    Browse the repository at this point in the history

  3. update doc 

    Signed-off-by: Chen Lihui <lihui.chen@sony.com>
    Chen Lihui committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    e280253 View commit details
    Browse the repository at this point in the history

  4. add one more test 

    Signed-off-by: Chen Lihui <lihui.chen@sony.com>
    Chen Lihui committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    98d21b3 View commit details
    Browse the repository at this point in the history

  5. explicitly use this to call a method inside the class itself 

    Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
    @ivanpauno
    Chen Lihui and ivanpauno committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    690a92d View commit details
    Browse the repository at this point in the history