-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use namespaces #328
Merged
Merged
Use namespaces #328
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
// Copyright 2017 Open Source Robotics Foundation, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef RCLCPP__EXPAND_TOPIC_OR_SERVICE_NAME_HPP_ | ||
#define RCLCPP__EXPAND_TOPIC_OR_SERVICE_NAME_HPP_ | ||
|
||
#include <string> | ||
|
||
#include "rclcpp/visibility_control.hpp" | ||
|
||
namespace rclcpp | ||
{ | ||
|
||
/// Expand a topic or service name and throw if it is not valid. | ||
/** | ||
* This function can be used to "just" validate a topic or service name too, | ||
* since expanding the topic name is required to fully validate a name. | ||
* | ||
* If the name is invalid, then InvalidTopicNameError is thrown or | ||
* InvalidServiceNameError if is_service is true. | ||
* | ||
* This function can take any form of a topic or service name, i.e. it does not | ||
* have to be a fully qualified name. | ||
* The node name and namespace are used to expand it if necessary while | ||
* validating it. | ||
* | ||
* Expansion is done with rcl_expand_topic_name. | ||
* The validation is doen with rcl_validate_topic_name and | ||
* rmw_validate_full_topic_name, so details about failures can be found in the | ||
* documentation for those functions. | ||
* | ||
* \param name the topic or service name to be validated | ||
* \param node_name the name of the node associated with the name | ||
* \param namespace_ the namespace of the node associated with the name | ||
* \param is_service if true InvalidServiceNameError is thrown instead | ||
* \returns expanded (and validated) topic name | ||
* \throws InvalidTopicNameError if name is invalid and is_service is false | ||
* \throws InvalidServiceNameError if name is invalid and is_service is true | ||
* \throws std::bad_alloc if memory cannot be allocated | ||
* \throws RCLError if an unexpect error occurs | ||
*/ | ||
RCLCPP_PUBLIC | ||
std::string | ||
expand_topic_or_service_name( | ||
const std::string & name, | ||
const std::string & node_name, | ||
const std::string & namespace_, | ||
bool is_service = false); | ||
|
||
} // namespace rclcpp | ||
|
||
#endif // RCLCPP__EXPAND_TOPIC_OR_SERVICE_NAME_HPP_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this not get a prefix/suffix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: 2ebf066