Deal with ParameterUninitializedException for parameter service #1033

Barry-Xu-2018 · 2022-11-01T09:14:25Z

Address #1030

Signed-off-by: Barry Xu <barry.xu@sony.com>

Barry-Xu-2018 · 2022-11-01T09:32:13Z

Not sure why test_parameter_client.py isn't included in CMakeLists.txt.

fujitatomoya · 2022-11-01T21:06:41Z

@Barry-Xu-2018 since this is draft, are you still working on this?

Barry-Xu-2018 · 2022-11-02T02:08:46Z

@Barry-Xu-2018 since this is draft, are you still working on this?

Yes.
iuhilnehc-ynos submitted a PR ros2/rclcpp#2036.
We should keep the same process for ParameterUninitializedException while getting parameter from parameter service.
We discussed it yesterday. So I marked the draft of this PR.

Signed-off-by: Barry Xu <barry.xu@sony.com>

fujitatomoya

lgtm

rclpy/CMakeLists.txt

fujitatomoya · 2022-11-10T18:42:34Z

@ivanpauno can you take a look at this too? it is the same change for ros2/rclcpp#2036

fujitatomoya · 2022-11-10T18:45:12Z

CI:

Linux
Linux-aarch64
Windows

Barry-Xu-2018 · 2022-11-11T10:41:22Z

About Linux failure, the cause seems to be related to CI environment

19:22:05 FATAL: command execution failed
19:22:24 java.nio.channels.ClosedChannelException
19:22:24 	at org.jenkinsci.remoting.protocol.NetworkLayer.onRecvClosed(NetworkLayer.java:154)
19:22:24 	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:142)
19:22:24 	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:790)
19:22:24 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
19:22:24 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
19:22:24 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
19:22:24 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
19:22:24 	at java.lang.Thread.run(Thread.java:748)
19:22:24 Caused: java.io.IOException: Backing channel 'JNLP4-connect connection from ip-10-0-1-44.ec2.internal/10.0.1.44:50798' is disconnected.

ivanpauno

LGTM

rclpy/CMakeLists.txt

Achllle · 2022-11-14T23:04:48Z

Given the crashing behavior, will this be backported to the currently supported Humble & Galactic?

fujitatomoya · 2022-11-15T21:14:41Z

@Mergifyio backport humble galactic foxy

* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py

* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/CMakeLists.txt # rclpy/rclpy/parameter_service.py # rclpy/test/test_parameter_client.py

mergify · 2022-11-15T21:15:34Z

backport humble galactic foxy

✅ Backports have been created

#1041 Deal with ParameterUninitializedException for parameter service (backport #1033) has been created for branch humble
#1042 Deal with ParameterUninitializedException for parameter service (backport #1033) has been created for branch galactic
#1043 Deal with ParameterUninitializedException for parameter service (backport #1033) has been created for branch foxy

…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py

…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Chen Lihui <lihui.chen@sony.com>

…#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com>

* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <florian@flova.de> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <florian@flova.de> Signed-off-by: Barry Xu <barry.xu@sony.com> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.6 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.7 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <barry.xu@sony.com> * Changed for filename with alphabet order Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <florian@flova.de> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Audrow Nash <audrow@openrobotics.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com>

* Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py

* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <florian@flova.de> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <florian@flova.de> Signed-off-by: Barry Xu <barry.xu@sony.com> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.6 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.7 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <barry.xu@sony.com> * Changed for filename with alphabet order Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <florian@flova.de> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Audrow Nash <audrow@openrobotics.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com>

…port #1033) (#1041) Signed-off-by: Barry Xu <barry.xu@sony.com>

Barry-Xu-2018 marked this pull request as draft November 1, 2022 09:14

Deal with ParameterUninitializedException for parameter service

9466d1d

Signed-off-by: Barry Xu <barry.xu@sony.com>

Barry-Xu-2018 force-pushed the topic-fix-not-deal-with-parameteruninitializedexception branch from 32a3792 to 9466d1d Compare November 1, 2022 09:28

Enable all tests in test_parameter_client.py

b3af04e

Signed-off-by: Barry Xu <barry.xu@sony.com>

Get empty value for ParameterUninitializedException

6b9458e

Signed-off-by: Barry Xu <barry.xu@sony.com>

Barry-Xu-2018 marked this pull request as ready for review November 2, 2022 03:57

fujitatomoya approved these changes Nov 10, 2022

View reviewed changes

rclpy/CMakeLists.txt Show resolved Hide resolved

fujitatomoya requested a review from ivanpauno November 10, 2022 18:42

ivanpauno approved these changes Nov 14, 2022

View reviewed changes

rclpy/CMakeLists.txt Show resolved Hide resolved

fujitatomoya merged commit e442ad2 into ros2:rolling Nov 14, 2022

mergify bot mentioned this pull request Nov 15, 2022

Deal with ParameterUninitializedException for parameter service (backport #1033) #1041

Merged

mergify bot mentioned this pull request Nov 15, 2022

Deal with ParameterUninitializedException for parameter service (backport #1033) #1042

Closed

mergify bot mentioned this pull request Nov 15, 2022

Deal with ParameterUninitializedException for parameter service (backport #1033) #1043

Closed

Barry-Xu-2018 mentioned this pull request Nov 18, 2022

Rewrite test code without depending on parameter client #1045

Merged

fujitatomoya pushed a commit that referenced this pull request Apr 25, 2023

Deal with ParameterUninitializedException for parameter service (back…

c718fd7

…port #1033) (#1041) Signed-off-by: Barry Xu <barry.xu@sony.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deal with ParameterUninitializedException for parameter service #1033

Deal with ParameterUninitializedException for parameter service #1033

Barry-Xu-2018 commented Nov 1, 2022

Barry-Xu-2018 commented Nov 1, 2022

fujitatomoya commented Nov 1, 2022

Barry-Xu-2018 commented Nov 2, 2022

fujitatomoya left a comment

fujitatomoya commented Nov 10, 2022

fujitatomoya commented Nov 10, 2022

Barry-Xu-2018 commented Nov 11, 2022

ivanpauno left a comment

Achllle commented Nov 14, 2022

fujitatomoya commented Nov 15, 2022

mergify bot commented Nov 15, 2022

Deal with ParameterUninitializedException for parameter service #1033

Deal with ParameterUninitializedException for parameter service #1033

Conversation

Barry-Xu-2018 commented Nov 1, 2022

Barry-Xu-2018 commented Nov 1, 2022

fujitatomoya commented Nov 1, 2022

Barry-Xu-2018 commented Nov 2, 2022

fujitatomoya left a comment

Choose a reason for hiding this comment

fujitatomoya commented Nov 10, 2022

fujitatomoya commented Nov 10, 2022

Barry-Xu-2018 commented Nov 11, 2022

ivanpauno left a comment

Choose a reason for hiding this comment

Achllle commented Nov 14, 2022

fujitatomoya commented Nov 15, 2022

mergify bot commented Nov 15, 2022

✅ Backports have been created