Fix test_publisher linter for pydocstyle 6.2.2
#1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
clalancette
approved these changes
Jan 4, 2023
|
CI:
|
fujitatomoya
approved these changes
Jan 4, 2023
delete-merged-branch
bot
deleted the
Crola1702/fix-test-subscriber-linter
branch
|
@Mergifyio backport humble |
|
https://github.com/Mergifyio backport galactic |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589)
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589)
✅ Backports have been created
|
|
@Mergifyio backport foxy |
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589)
✅ Backports have been created
|
Crola1702
added a commit
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589) Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Crola1702
added a commit
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589) Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
adityapande-1995
pushed a commit
that referenced
this pull request
Jan 23, 2023
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit fb10589) Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com>
sebastian-freitag
added a commit
to fernride/rclpy
that referenced
this pull request
Jan 26, 2023
Fix test_publisher linter for pydocstyle 6.2.2 (ros2#1063) Signed-off-by: Sebastian Freitag <sebastian.freitag@pylot.tech>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ros2#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ros2#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
pushed a commit
to iuhilnehc-ynos/rclpy
that referenced
this pull request
Apr 10, 2023
…ros2#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclpy
that referenced
this pull request
Apr 10, 2023
…ros2#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Barry Xu <barry.xu@sony.com>
fujitatomoya
added a commit
that referenced
this pull request
Apr 12, 2023
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <florian@flova.de> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <florian@flova.de> Signed-off-by: Barry Xu <barry.xu@sony.com> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.6 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.7 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <barry.xu@sony.com> * Changed for filename with alphabet order Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <florian@flova.de> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Audrow Nash <audrow@openrobotics.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
fujitatomoya
added a commit
that referenced
this pull request
Apr 21, 2023
* Add parallel callback test (#1044) (#1052) * Add parallel callback test Signed-off-by: Florian Vahl <florian@flova.de> (cherry picked from commit 40054ba) Co-authored-by: Florian Vahl <florian@flova.de> Signed-off-by: Barry Xu <barry.xu@sony.com> * decorator should not be callable. (#1050) (#1051) #1047 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 2da35a4) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.6 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix `test_publisher` linter for pydocstyle 6.2.2 (backport #1063) (#1066) Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * 3.3.7 Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix #983 by saving future and checking for + raising any exceptions (#1073) (#1088) * Fix #983 by saving future and checking for + raising any exceptions Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com> Signed-off-by: Barry Xu <barry.xu@sony.com> * Deal with ParameterUninitializedException for parameter service (#1033) * Deal with ParameterUninitializedException for parameter service Signed-off-by: Barry Xu <barry.xu@sony.com> * Enable all tests in test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Get empty value for ParameterUninitializedException Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit e442ad2) # Conflicts: # rclpy/test/test_parameter_client.py Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix conflict and use new testcase (#1053) Signed-off-by: Barry Xu <barry.xu@sony.com> * Changed for filename with alphabet order Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Audrow Nash <audrow@openrobotics.org> Signed-off-by: Achille Verheye <achille.verheye@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Florian Vahl <florian@flova.de> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Audrow Nash <audrow@openrobotics.org> Co-authored-by: Cristóbal Arroyo <69475004+Crola1702@users.noreply.github.com> Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com
do_test_topic_namedocstring is different from others in rclpy (e.g., utilities), this causes a test regression in pep257 with the new pydocstyle 6.2.0 version.This PR changes this docstring format, so it can pass pep257 tests.
Reference builds: