Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_publisher linter for pydocstyle 6.2.2 (backport #1063) #1068

Merged
merged 1 commit into from Jan 23, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 9, 2023

This is an automatic backport of pull request #1063 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
(cherry picked from commit fb10589)
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@Crola1702
Copy link
Contributor

Crola1702 commented Jan 20, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

We don't support rhel in Foxy:

  • Linux-rhel Build Status

Copy link

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows warnings seem unrelated

@adityapande-1995 adityapande-1995 merged commit c0bf7e1 into foxy Jan 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/foxy/pr-1063 branch January 23, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants