Cleanup of test_node.py. #1153
Merged
Cleanup of test_node.py. #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests weren't always properly cleaning up after
themselves, and were sometimes improperly using the
setUp{Class} fixtures. They also didn't always clean up
between tests, so sometimes the same node was reused
over and over again. Clean all that up here, which
should make the tests much more robust.
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests weren't always properly cleaning up after themselves, and were sometimes improperly using the setUp{Class} fixtures. They also didn't always clean up between tests, so sometimes the same node was reused over and over again. Clean all that up here, which should make the tests much more robust.