New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to logging_service.py #1227
Conversation
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Would the maintainers prefer a small PR per file like I have currently been doing? Or do you all have some other preference? |
Small PRs are much preferred; they are much easier to review and run CI for. Thanks! |
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with green CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for iterating! I'll run CI on it next.
Any idea if my changes caused these regressions or is it an unrelated? @clalancette |
The failed tests are unrelated here, so I'm going to go ahead and merge this in. |
* add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Start typing time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Lint fixes Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add debug message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove test file Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Try extending the type assert Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * update type alias name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove newline Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Merge? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix failed merge Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import error Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Linty Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Add types to logging_service.py (ros2#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* Start typing time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Lint fixes Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add debug message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove test file Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Try extending the type assert Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to logging_service.py (ros2#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * update type alias name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove newline Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Merge? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix failed merge Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import error Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Linty Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
* First draft of generics Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix Generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add legacy Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix import order Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add generics support to Node Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to expand_topic_name (#1238) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Creates Enum wrapper for ClockType and ClockChange (#1235) * Testing out Enum wrapper for ClockType * convert to rcl_clock_type_t * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types (#1231) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to exceptions.py (#1241) * Add types to exception * Add type checking guard * Fix NotInitializedException * Add missing defualt Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * added python3-yaml (#1242) Signed-off-by: SnIcK <ido.samuelson@gmail.com> Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py (#1233) * Add types to logging_service.py (#1227) * add types to logging_service * Add types to duration.py * Add newlines for class definintions * update type alias name * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add Static Typing to Validate files (#1230) * Add types to validate files Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove type annotations from docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * removed other type annotated docstrings Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to TypeHash and moved away from __slots__ usage (#1232) * Add types to TypeHash and moved away from __slots__ usage Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * remove docstring types Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Time.py Types (#1237) * Start typing time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Testing out Enum wrapper for ClockType Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * convert to rcl_clock_type_t Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Undo Change to time_point.cpp Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update create_time_point Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Lint fixes Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add debug message Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove test file Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Try extending the type assert Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to logging_service.py (#1227) * add types to logging_service Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to duration.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add newlines for class definintions Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * update type alias name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Remove newline Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Merge? Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix failed merge Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update to use Protocols Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix import error Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to time.py Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Linty Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Revert "Add types to TypeHash and moved away from __slots__ usage (#1232)" (#1243) This reverts commit b06baef. Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add back Type hash __slots__ and add test cases. (#1245) * Add types to TypeHash and add test cases Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add types to context.py (#1240) Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * fix pub and sub Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update LifecyclePublisher Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix docstring Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * serialization generic Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Update type_support.py Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> Signed-off-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com> Signed-off-by: SnIcK <ido.samuelson@gmail.com> Signed-off-by: Shane Loretz <sloretz@intrinsic.ai> Co-authored-by: SnIcK <ido.samuelson@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Shane Loretz <sloretz@intrinsic.ai>
Added static typing to logging_service.py. This change was already done similarly in #979 in response to issue #976. Also fixes a spelling error of Invaild -> Invalid.